Messages in this thread | | | Date | Wed, 17 Jul 2013 15:20:16 +0300 | From | Dan Carpenter <> | Subject | Re: [patch] Squashfs: sanity check information from disk |
| |
On Wed, Jul 17, 2013 at 05:20:31AM +0100, Phillip Lougher wrote: > On 15 July 2013 17:17, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > We read the size of the name from the disk, but a larger name than > > expected would cause memory corruption. > > Thanks for the patch, it's queued for the next merge window. There's > one mistake with the patch, but I can fix it when it's applied, or you > can send a revised patch (see later).
I wouldn't call it a "mistake", it's just a difference in prefered styles. The two statements:
if (size >= SQUASHFS_NAME_LEN + 1) { and if (size > SQUASHFS_NAME_LEN) {
These statements are equivalent. But I can change it, no worries.
regards, dan carpenter
| |