Messages in this thread | | | From | Prabhakar Lad <> | Date | Wed, 17 Jul 2013 14:05:18 +0530 | Subject | Re: [PATCH RFC v4] media: OF: add "sync-on-green-active" property |
| |
Hi Sylwester,
Thanks for the review.
On Wed, Jul 17, 2013 at 2:08 AM, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote: > Hi Prabhakar, > > [snip] >> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt >> b/Documentation/devicetree/bindings/media/video-interfaces.txt >> index e022d2d..5186c7e 100644 >> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt >> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt >> @@ -101,6 +101,9 @@ Optional endpoint properties >> array contains only one entry. >> - clock-noncontinuous: a boolean property to allow MIPI CSI-2 >> non-continuous >> clock mode. >> +- sync-on-green-active: polarity field when video synchronization is >> + Sync-On-Green. When set the driver determines whether it's a normal >> operation >> + or inverted operation. > > > Would you mind adding this entry after pclk-sample property description ?
OK.
> And how about describing it a bit more precisely and similarly to > VSYNC/HSYNC, > e.g. > > - sync-on-green-active: active state of Sync-on-green (SoG) signal, > 0/1 for LOW/HIGH respectively. > OK I'll paste the above one itself :-)
-- Regards, Prabhakar Lad
| |