lkml.org 
[lkml]   [2013]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter
Il 15/07/2013 20:12, Joe Perches ha scritto:
> On Mon, 2013-07-15 at 20:01 +0200, Paolo Valente wrote:
>> QFQ+ inherits from QFQ a design choice that may cause a high packet
>> delay/jitter and a severe short-term unfairness.
> []
>> diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
> []
>> @@ -189,6 +188,7 @@ struct qfq_sched {
>> struct qfq_aggregate *in_serv_agg; /* Aggregate being served. */
>> u32 num_active_agg; /* Num. of active aggregates */
>> u32 wsum; /* weight sum */
>> + unsigned long iwsum; /* inverse weight sum*/
>
> This is a different size for 32/64 bit compiles
> and may be better as u32.
>
>
Sending a new version with u32, thanks.


\
 
 \ /
  Last update: 2013-07-16 09:41    [W:0.041 / U:4.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site