Messages in this thread | | | Date | Tue, 16 Jul 2013 17:01:23 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH v8] ARM: clocksource: add support for MOXA ART SoCs |
| |
On 07/16/2013 04:44 PM, Jonas Jensen wrote: > This patch adds an clocksource driver for the main timer(s) > found on MOXA ART SoCs. > > Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com> > ---
Ok, I will ask you two more things before taking your patch. I missed them at the previous review, sorry for asking a new version.
1. could you elaborate the patch log: as it is a new driver, a nice description of the timer hardware would be valuable for people willing to understand the code (eg. some specificities of the driver).
2. fix the alignment below
Thanks -- Daniel
[ ... ]
> + > +#define TIMER_CR 0x30 > +#define TIMER_INTR_STATE 0x34 > +#define TIMER_INTR_MASK 0x38
[ ... ]
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |