Messages in this thread | | | Subject | Re: [PATCH 3/3] kconfig: cleanup symbol-search code | From | Jean Delvare <> | Date | Tue, 16 Jul 2013 16:33:47 +0200 |
| |
Le Saturday 13 July 2013 à 20:08 +0200, Yann E. MORIN a écrit : > From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > - no need for a double-indirection for the temporary sym_match_arr array > - the temporary sym_match_arr array is not NULL terminated, so no need > to allocate n+1 elements > - two minor style fixes > - grammar fix in comment > > Reported-by: Jean Delvare <jdelvare@suse.de> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Jean Delvare <jdelvare@suse.de> > --- > scripts/kconfig/symbol.c | 39 +++++++++++++++------------------------ > 1 file changed, 15 insertions(+), 24 deletions(-) > (...)
You mixed style cleanups with actual code changes, which is usually avoided. Michal may ask you to split these changes into two separate patches.
Still, I'm happy with all the changes:
Reviewed-by: Jean Delvare <jdelvare@suse.de>
-- Jean Delvare Suse L3
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |