Messages in this thread | | | Date | Tue, 16 Jul 2013 07:20:10 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH] perf, tools, bench: Fix memcpy benchmark for large sizes |
| |
> > @@ -117,6 +117,8 @@ static void alloc_mem(void **dst, void **src, size_t length) > > *src = zalloc(length); > > if (!src) > > die("memory allocation failed - maybe length is too large?\n"); > > + /* Make sure to always replace the zero pages even if MMAP_THRESH is crossed */ > > + memset(src, 0, length); > > It should be memset(*src, 0, length) instead.
Thanks for catching. I wonder why it fixed the problem for me.
> There's fix for wrong memory allocation fail check in v3.11-rc1.
Doubt it matters.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |