lkml.org 
[lkml]   [2013]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/hugetlb: per-vma instantiation mutexes
On Mon, 15 Jul 2013 17:24:32 +1000 David Gibson <david@gibson.dropbear.id.au> wrote:

> I have previously proposed a correct method of improving scalability,
> although it doesn't eliminate the lock. That's to use a set of hashed
> mutexes.

Yep - hashing the mutexes is an obvious and nicely localized way of
improving this. It's a tweak, not a design change.

The changelog should describe the choice of the hash key with great
precision, please. It's important and is the first thing which
reviewers and readers will zoom in on.

Should the individual mutexes be cacheline aligned? Depends on the
acquisition frequency, I guess. Please let's work through that.

Let's not damage uniprocesor kernels too much. AFACIT the main offender
here is fault_mutex_hash(), which is the world's most obfuscated "return
0;".

> It wasn't merged before, but I don't recall the reasons
> why.

Me either.


\
 
 \ /
  Last update: 2013-07-16 01:41    [W:0.101 / U:3.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site