| Date | Mon, 15 Jul 2013 15:25:47 +0530 | Subject | Re: [PATCH 7/8] cpufreq: Preserve policy structure across suspend/resume | From | Viresh Kumar <> |
| |
Hi Srivatsa,
I may be wrong but it looks something is wrong in this patch.
On 12 July 2013 03:47, Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> wrote: > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> @@ -1239,29 +1263,40 @@ static int __cpufreq_remove_dev(struct device *dev, > if ((cpus == 1) && (cpufreq_driver->target)) > __cpufreq_governor(data, CPUFREQ_GOV_POLICY_EXIT); > > - pr_debug("%s: removing link, cpu: %d\n", __func__, cpu); > - cpufreq_cpu_put(data); > + if (!frozen) { > + pr_debug("%s: removing link, cpu: %d\n", __func__, cpu); > + cpufreq_cpu_put(data);
So, we don't decrement usage count here. But we are still increasing counts on cpufreq_add_dev after resume, isn't it?
So, we wouldn't be able to free policy struct once all the cpus of a policy are removed after suspend/resume has happened once.
|