Messages in this thread | | | Date | Fri, 12 Jul 2013 11:11:23 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH 1/2] fb: backlight: HX8357: Make IM pins optionnal |
| |
On Tue, Jun 25, 2013 at 03:50:15PM +0200, Maxime Ripard wrote: > > > }; > > > > > > static u8 hx8357_seq_power[] = { > > > @@ -250,9 +251,11 @@ static int hx8357_lcd_init(struct lcd_device *lcdev) > > > * Set the interface selection pins to SPI mode, with three > > > * wires > > > */ > > > - gpio_set_value_cansleep(lcd->im_pins[0], 1); > > > - gpio_set_value_cansleep(lcd->im_pins[1], 0); > > > - gpio_set_value_cansleep(lcd->im_pins[2], 1); > > > + if (lcd->use_im_pins) { > > > + gpio_set_value_cansleep(lcd->im_pins[0], 1); > > > + gpio_set_value_cansleep(lcd->im_pins[1], 0); > > > + gpio_set_value_cansleep(lcd->im_pins[2], 1); > > > + } > > > > base on the dt probe you may have gpios betwee 0 to HX8357_NUM_IM_PINS > > > > so this look wrong > > How so? > > HX8357_NUM_IM_PINS is defined to 3, the probe checks to see if we > actually have HX8357_NUM_IM_PINS, otherwise returns an error, what is > wrong in setting these pins here?
Ping?
I'd really like to get this merged, could you clarify what you want?
Thanks, Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |