Messages in this thread | | | Date | Wed, 10 Jul 2013 16:39:02 +0200 | From | Ingo Molnar <> | Subject | Re: sched: add notifier for cross-cpu migrations |
| |
* Peter Zijlstra <peterz@infradead.org> wrote:
> Hi, > > I just stumbled over commit 582b336ec2 and had a massive WTF moment. > > The Changelog -- empty! > The Implementation -- complete crap! > > fail^2. > > A git grep later I find its x86_64 paravirt only.. for this we add > unconditional crap to the scheduler? > > At the _very_ least this should have been wrapped in a static_key and > the changelog should have given some clue as to the what and why of this > code.
My bad for letting it slip through...
Marcelo, mind implementing the suggestions from Peter?
Thanks,
Ingo
| |