lkml.org 
[lkml]   [2013]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: sched: add notifier for cross-cpu migrations
Hi,

I just stumbled over commit 582b336ec2 and had a massive WTF moment.

The Changelog -- empty!
The Implementation -- complete crap!

fail^2.

A git grep later I find its x86_64 paravirt only.. for this we add
unconditional crap to the scheduler?

At the _very_ least this should have been wrapped in a static_key and the
changelog should have given some clue as to the what and why of this code.

/me grumpy


\
 
 \ /
  Last update: 2013-07-10 23:53    [W:0.106 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site