lkml.org 
[lkml]   [2013]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] m68k/mac: Allocate IOP message pool and queues dynamically
On Mon, Jul 01, 2013 at 05:46:48PM +1000, Finn Thain wrote:
>
> On Sun, 30 Jun 2013, Geert Uytterhoeven wrote:
>
> > -
> > -/*
> > - * Register the interrupt handler for the IOPs.
> > - * TODO: might be wrong for non-OSS machines. Anyone?
> > - */
> > -
> > -void __init iop_register_interrupts(void)
> > -{
> > - if (iop_ism_present) {
> > + /*
> > + * Register the interrupt handler for the IOPs.
> > + * TODO: might be wrong for non-OSS machines. Anyone?
>
> My testing with a non-OSS machine (Quadra 950) indicates that the TODO is
> obsolete. And the comment "register the interrupt handler for the IOPs" is
> a bit silly. It merely re-phrases the code. Otherwise, this patch looks
> good to me. Thanks.

The code was all originally written and tested only on the IIfx. That's
all JMT had, and at the time it was all I had as well. I have since
acquired a Quadra 950. Lots of these comments are just out of date. I
know it got tested on either a Quadra 900 or Quadra 950 after that
comment was put in the source.

Brad Boyer
flar@allandria.com



\
 
 \ /
  Last update: 2013-07-02 00:41    [W:0.071 / U:12.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site