lkml.org 
[lkml]   [2013]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 8/8] isdn: clean up debug format string usage
From
On Thu, Jun 6, 2013 at 1:52 PM, Kees Cook <keescook@chromium.org> wrote:
> Avoid unneeded local string buffers for constructing debug output. Also
> cleans up debug calls that contain a single parameter so that they cannot
> be accidentally parsed as format strings.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> [...]
> diff --git a/drivers/isdn/mISDN/dsp_pipeline.c b/drivers/isdn/mISDN/dsp_pipeline.c
> index 8b1a66c..88305c9 100644
> --- a/drivers/isdn/mISDN/dsp_pipeline.c
> +++ b/drivers/isdn/mISDN/dsp_pipeline.c
> @@ -102,7 +102,7 @@ int mISDN_dsp_element_register(struct mISDN_dsp_element *elem)
> entry->dev.class = elements_class;
> entry->dev.release = mISDN_dsp_dev_release;
> dev_set_drvdata(&entry->dev, elem);
> - dev_set_name(&entry->dev, "%s", elem->name);
> + dev_set_name(&entry->dev, elem->name);
> ret = device_register(&entry->dev);
> if (ret) {
> printk(KERN_ERR "%s: failed to register %s\n",

This hunk should be dropped -- it got mixed up when splitting the
dev_set_name() patch out.

-Kees

--
Kees Cook
Chrome OS Security


\
 
 \ /
  Last update: 2013-06-07 21:21    [W:0.207 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site