lkml.org 
[lkml]   [2013]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ 150/184] ipv4: check rt_genid in dst_check
Hi Willy,

On Fri, Jun 07, 2013 at 05:00:57PM +0200, Willy Tarreau wrote:
> On Fri, Jun 07, 2013 at 10:58:06AM -0400, Benjamin LaHaise wrote:
> > On Fri, Jun 07, 2013 at 07:07:33AM +0100, Ben Hutchings wrote:
> > > > This commit is based on the above, with the addition of verifying blackhole
> > > > routes in the same manner.
> > >
> > > That addition doesn't seem to correspond to anything in mainline. Why
> > > should 2.6.32 differ?
> >
> > Fixing the issue with blackhole routes as it was accomplished in mainline
> > would require pulling in a lot more code, and people were not interested
> > in pulling in all of the dependencies given the much higher risk of trying
> > to select the right subset of changes to include. The addition of the
> > single line of "dst->obsolete = -1;" in ipv4_dst_blackhole() was much
> > easier to verify, and is in the spirit of the patch in question. This is
> > the minimal set of changes to fix the bug in question.
>
> Thank you Ben, I'll add this description to the existing commit message.

A link to the test case for this issue might be helpful to include as well.
It is at http://marc.info/?l=linux-netdev&m=135015076708950&w=2 . Cheers,

-ben

> Best regards,
> Willy

--
"Thought is the essence of where you are now."


\
 
 \ /
  Last update: 2013-06-07 17:21    [W:0.102 / U:2.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site