Messages in this thread | | | Date | Fri, 07 Jun 2013 18:16:05 +0400 | From | Roman Gushchin <> | Subject | Re: [patch 09/10] mm: thrash detection-based file cache sizing |
| |
On 30.05.2013 22:04, Johannes Weiner wrote: > +/* > + * Monotonic workingset clock for non-resident pages. > + * > + * The refault distance of a page is the number of ticks that occurred > + * between that page's eviction and subsequent refault. > + * > + * Every page slot that is taken away from the inactive list is one > + * more slot the inactive list would have to grow again in order to > + * hold the current non-resident pages in memory as well. > + * > + * As the refault distance needs to reflect the space missing on the > + * inactive list, the workingset time is advanced every time the > + * inactive list is shrunk. This means eviction, but also activation. > + */ > +static atomic_long_t workingset_time;
It seems strange to me, that workingset_time is global. Don't you want to make it per-cgroup?
Two more questions: 1) do you plan to take fadvise's into account somehow? 2) do you plan to use workingset information to enhance the readahead mechanism?
Thanks!
Regards, Roman
| |