Messages in this thread | | | Date | Fri, 7 Jun 2013 11:50:45 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic |
| |
On Fri, Jun 07, 2013 at 11:40:25AM +0200, Johan Hovold wrote: > On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > [...] > > > /* Functions needed by other parts of the usbserial core */ > > -extern struct usb_serial *usb_serial_get_by_index(unsigned int minor); > > +extern struct usb_serial_port *usb_serial_port_get_by_minor(unsigned int minor); > > As Tobias already noted, this breaks the USB console driver. However, it > looks like the call in that driver is not really needed and that > therefore usb_serial_port_get_by_minor need not be exported at all.
Forget that last sentence. It is still needed, of course.
Johan
| |