lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] keucr: restored lost line
On Thu, Jun 06, 2013 at 10:50:51PM +0200, Laura Lawniczak wrote:
> This line was unfortunately removed during patch process. This caused an
> "unused variable" warning and may cause other unintended effects.
> So here it is again.
>
> Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>
> ---
> drivers/staging/keucr/transport.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/keucr/transport.c b/drivers/staging/keucr/transport.c
> index 1f9ea58..c47a035 100644
> --- a/drivers/staging/keucr/transport.c
> +++ b/drivers/staging/keucr/transport.c
> @@ -131,6 +131,7 @@ static void usb_stor_print_cmd(struct us_data *us, struct scsi_cmnd *srb)
> break;
> }
> bn = 0;
> + blen = 0;

Really? If it's unused, why do you want to set it to something? Any
why is bn set to 0 at the end of the function as well?

Shouldn't both of these lines be removed, and the variable itself
removed too?

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-06-07 00:21    [W:0.107 / U:6.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site