lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] keucr: restored lost line
On Thu, Jun 06, 2013 at 10:50:51PM +0200, Laura Lawniczak wrote:
> This line was unfortunately removed during patch process. This caused an
> "unused variable" warning and may cause other unintended effects.
> So here it is again.
>

Oh wow... I noticed this in the first patch and I couldn't figure
out why the blen = 0 was there... It never occurred to me that it
was to silence the warning. :P That's hilarious.

The blen variable is only used in commented out code. Don't do
this. Please delete everything to do with blen. It's there in the
history if anyone wants to see it. Delete "bn" as well.

regards,
dan carpenter



\
 
 \ /
  Last update: 2013-06-07 00:21    [W:0.054 / U:6.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site