lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/8] power: ensure event is not used as format string
    Date
    The exposed interface for cm_notify_event() could result in the event
    msg string being parsed as a format string. Make sure it is only used
    as a literal string.

    Signed-off-by: Kees Cook <keescook@chromium.org>
    Cc: stable@vger.kernel.org
    Cc: Anton Vorontsov <cbou@mail.ru>
    Cc: David Woodhouse <dwmw2@infradead.org>
    ---
    drivers/power/charger-manager.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
    index fefc39f..98de1dd 100644
    --- a/drivers/power/charger-manager.c
    +++ b/drivers/power/charger-manager.c
    @@ -450,7 +450,7 @@ static void uevent_notify(struct charger_manager *cm, const char *event)
    strncpy(env_str, event, UEVENT_BUF_SIZE);
    kobject_uevent(&cm->dev->kobj, KOBJ_CHANGE);

    - dev_info(cm->dev, event);
    + dev_info(cm->dev, "%s", event);
    }

    /**
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-06-06 23:21    [W:5.166 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site