lkml.org 
[lkml]   [2013]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 16/44] perf: net_dropmonitor: Fix symbol-relative addresses
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ben Hutchings <ben@decadent.org.uk>

    commit 5a1e99dd2028e00998d42029be86835d8ef4a46e upstream.

    The comparison between traced and symbol addresses is backwards: if
    the traced address doesn't exactly match a symbol (which we don't
    expect it to), we'll show the next symbol and the offset to it,
    whereas we should show the previous symbol and the offset from it.

    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    tools/perf/scripts/python/net_dropmonitor.py | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/tools/perf/scripts/python/net_dropmonitor.py
    +++ b/tools/perf/scripts/python/net_dropmonitor.py
    @@ -40,9 +40,9 @@ def get_kallsyms_table():

    def get_sym(sloc):
    loc = int(sloc)
    - for i in kallsyms:
    - if (i['loc'] >= loc):
    - return (i['name'], i['loc']-loc)
    + for i in kallsyms[::-1]:
    + if loc >= i['loc']:
    + return (i['name'], loc - i['loc'])
    return (None, 0)

    def print_drop_table():



    \
     
     \ /
      Last update: 2013-06-05 23:41    [W:2.105 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site