Messages in this thread Patch in this message | | | From | Rasmus Villemoes <> | Subject | [PATCH] drivers: use IS_ERR_VALUE() in memory_lseek() | Date | Wed, 5 Jun 2013 17:09:39 +0000 |
| |
Use IS_ERR_VALUE() instead of comparing the new offset to a hard-coded value of -MAX_ERRNO (which is also off-by-one due to the use of ~ instead of -).
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- drivers/char/mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/mem.c b/drivers/char/mem.c index 1ccbe94..2ca6d78 100644 --- a/drivers/char/mem.c +++ b/drivers/char/mem.c @@ -745,7 +745,7 @@ static loff_t memory_lseek(struct file *file, loff_t offset, int orig) offset += file->f_pos; case SEEK_SET: /* to avoid userland mistaking f_pos=-9 as -EBADF=-9 */ - if ((unsigned long long)offset >= ~0xFFFULL) { + if (IS_ERR_VALUE((unsigned long long)offset)) { ret = -EOVERFLOW; break; } -- 1.7.9.5
| |