Messages in this thread | | | Date | Wed, 05 Jun 2013 16:53:02 +0200 | From | Michal Simek <> | Subject | Re: [PATCH] audit: Fix decimal constant description |
| |
Hi guys,
any comment on this?
Geert: I fixes one warning reported in your regression log.
Thanks, Michal
On 05/23/2013 08:03 AM, Michal Simek wrote: > Use proper decimal type for comparison with u32. > > Compilation warning was introduced by: > "audit: Make testing for a valid loginuid explicit." > (sha1: 780a7654cee8d61819512385e778e4827db4bfbc) > > Warning: > kernel/auditfilter.c: In function 'audit_data_to_entry': > kernel/auditfilter.c:426:3: warning: this decimal constant > is unsigned only in ISO C90 [enabled by default] > if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) { > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > CC: Al Viro <viro@zeniv.linux.org.uk> > CC: Eric Paris <eparis@redhat.com> > --- > kernel/auditfilter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c > index 83a2970..cfa1f73 100644 > --- a/kernel/auditfilter.c > +++ b/kernel/auditfilter.c > @@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data, > f->lsm_rule = NULL; > > /* Support legacy tests for a valid loginuid */ > - if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) { > + if ((f->type == AUDIT_LOGINUID) && (f->val == ~0U)) { > f->type = AUDIT_LOGINUID_SET; > f->val = 0; > } > -- > 1.8.2.3 >
-- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[unhandled content-type:application/pgp-signature] | |