lkml.org 
[lkml]   [2013]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h
Date
On Tuesday 04 June 2013 17:24:51 Rob Herring wrote:
>
> Right. I get all that. You still have to go add inlines if you want to make:
>
> if (IS_ENABLED(CONFIG_OF))
> of_foo();
>
> just be:
>
> of_foo();
>
> There are situations for both and only inlines cover both cases. I
> don't see a reason we would want to allow the first case and not allow
> the second case. I am tired of taking patches adding the inlines 1 by
> 1, so perhaps we need to refactor the OF headers to better separate
> core infrastructure includes vs. driver only includes if that is
> really a concern.

Ok, fair enough. Putting internal declarations into a local header
file would be best of course.

Arnd


\
 
 \ /
  Last update: 2013-06-05 14:41    [W:1.119 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site