Messages in this thread Patch in this message | | | Date | Tue, 04 Jun 2013 19:22:04 +0200 | From | Willy Tarreau <> | Subject | [ 034/184] tracing: Fix double free when function profile init |
| |
2.6.32-longterm review patch. If anyone has any objections, please let me know.
------------------ failed
From: Namhyung Kim <namhyung.kim@lge.com>
commit 83e03b3fe4daffdebbb42151d5410d730ae50bd1 upstream.
On the failure path, stat->start and stat->pages will refer same page. So it'll attempt to free the same page again and get kernel panic.
Link: http://lkml.kernel.org/r/1364820385-32027-1-git-send-email-namhyung@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Namhyung Kim <namhyung.kim@lge.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Willy Tarreau <w@1wt.eu> --- kernel/trace/ftrace.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 4872937..c5f8ab9 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -469,7 +469,6 @@ int ftrace_profile_pages_init(struct ftrace_profile_stat *stat) free_page(tmp); } - free_page((unsigned long)stat->pages); stat->pages = NULL; stat->start = NULL; -- 1.7.12.2.21.g234cd45.dirty
| |