Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCHv2 1/3] net: phy: prevent linking breakage | Date | Tue, 04 Jun 2013 19:17:59 +0200 |
| |
On Tuesday 04 June 2013 17:09:26 Florian Fainelli wrote: > You would just need to define a stub for your arch_foo_phy_fixup() > which has a different definition depending on whether CONFIG_PHYLIB is > defined or not.
Yes, same thing. For a function that is called in only one place, I would always prefer if(IS_ENABLED()) over a stub though.
> This would be just one function, instead of the whole bunch of stubs > needed for phylib. Right now its probably 1 vs 3, so it does not make > that much of a difference but who knows, if we had more phylib stubs > and forget to update the stubs? (which tends to happen pretty often). > > The size savings are exactly the same in both approaches anyway.
So should we just stick to the current method then and use if (IS_ENABLED(CONFIG_NET)) for calling the function?
Arnd
| |