Messages in this thread | | | Date | Tue, 4 Jun 2013 17:57:38 +0300 | Subject | Re: [PATCH, resend] pch_phub: re-use native MAC address parser | From | Andy Shevchenko <> |
| |
On Tue, Jun 4, 2013 at 5:38 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Tuesday 04 June 2013 17:21:16 Andy Shevchenko wrote: > >> > The easiest solution would be to >> > make the entire driver "depend on NET". >> >> I don't feel that is good idea. Driver is an abstraction to the ROM, >> it doesn't mean you can't read ROM without network framework. > > Right, makes sense. > >> It seems proper solution is to move mac_pton() outside of CONFIG_NET, >> though I don't know how to do this easily. > > If we want to use it outside of CONFIG_NET, it cannot be part of net/core/*.c. > Maybe we can move the function to lib/mac_pton.c instead and create a > Kconfig symbol that gets selected by CONFIG_NET and by any driver lib > PCH_PHUB that needs it.
Sounds like a solution. Would you like me to implement this?
-- With Best Regards, Andy Shevchenko
| |