Messages in this thread | | | Subject | Re: [PATCH] m68k/setup: Use pr_*() instead of plain printk() | From | Joe Perches <> | Date | Sun, 30 Jun 2013 15:22:28 -0700 |
| |
On Sun, 2013-06-30 at 11:48 +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Hi Geert, just trivial comments...
> diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
> @@ -161,7 +161,7 @@ static void __init m68k_parse_bootinfo(const struct bi_record *record) [] > - printk("m68k_parse_bootinfo: too many memory chunks\n"); > + pr_warn("m68k_parse_bootinfo: too many memory chunks\n");
These are generally better written by removing the hand-written function name and using "%s: ", __func__
pr_warn("%s: too many memory chunks\n", __func__);
> @@ -197,8 +197,8 @@ static void __init m68k_parse_bootinfo(const struct bi_record *record)
> - printk("m68k_parse_bootinfo: unknown tag 0x%04x ignored\n", > - record->tag); > + pr_warn("m68k_parse_bootinfo: unknown tag 0x%04x ignored\n", > + record->tag);
etc.
> @@ -538,9 +538,9 @@ void check_bugs(void) > { > #ifndef CONFIG_M68KFPU_EMU > if (m68k_fputype == 0) { > - printk(KERN_EMERG "*** YOU DO NOT HAVE A FLOATING POINT UNIT, " > + pr_emerg("*** YOU DO NOT HAVE A FLOATING POINT UNIT, " > "WHICH IS REQUIRED BY LINUX/M68K ***\n"); > - printk(KERN_EMERG "Upgrade your hardware or join the FPU " > + pr_emerg("Upgrade your hardware or join the FPU " > "emulation project\n");
It would be nicer to coalesce the formats into a single line.
| |