lkml.org 
[lkml]   [2013]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH v1 6/8] zram: avoid access beyond the zram device
    Date
    Function valid_io_request() should verify the entire request doesn't
    exceed the zram device, otherwise it will cause invalid memory access.

    Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
    ---
    drivers/staging/zram/zram_drv.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
    index 66cf28a..64b51b9 100644
    --- a/drivers/staging/zram/zram_drv.c
    +++ b/drivers/staging/zram/zram_drv.c
    @@ -428,6 +428,10 @@ static inline int valid_io_request(struct zram *zram, struct bio *bio)
    return 0;
    }

    + if (unlikely((bio->bi_sector << SECTOR_SHIFT) + bio->bi_size >=
    + zram->disksize))
    + return 0;
    +
    /* I/O request is valid */
    return 1;
    }
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-06-03 18:46    [W:4.661 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site