Messages in this thread | | | Date | Mon, 3 Jun 2013 07:26:54 -0700 | From | Greg KH <> | Subject | Re: [char-misc 3.10] mei: nfc: fix nfc device freeing |
| |
On Mon, Jun 03, 2013 at 09:28:30AM +0300, Tomas Winkler wrote: > The nfc_dev is a static variable and is not cleaned properly upon reset > mainly ndev->cl and ndev->cl_info are not set to NULL after freeing which
Then it needs to be made dynamic, don't paper over the bug by zeroing it out, you really have a much larger issue here that just hasn't hit you yet.
No 'struct device' should ever be in a static variable, please fix this properly.
thanks,
greg k-h
| |