Messages in this thread | | | Date | Mon, 3 Jun 2013 11:50:26 +0200 | From | Johannes Thumshirn <> | Subject | Re: [PATCH v6] watchdog: New watchdog driver for MEN A21 watchdogs |
| |
On Fri, May 31, 2013 at 09:15:23PM -0700, Guenter Roeck wrote: > On Fri, May 31, 2013 at 02:55:19PM +0200, Johannes Thumshirn wrote: > > Hi Guenther, > > On Fri, May 31, 2013 at 04:40:37AM -0700, Guenter Roeck wrote: > > > > +#define GPIO_WD_ENAB 169 > > > > +#define GPIO_WD_FAST 170 > > > > +#define GPIO_WD_TRIG 171 > > > > + > > > > +#define GPIO_RST_CAUSE_BASE 166 > > > > + > > > > > > I think I asked that before ... as you are supporting devicetree, gpio pins > > > should really be provided through devicetree properties and not be hardcoded. > > > > > Yes you did and I didn't come up with a solution to this problem yet. I understand > > and agree to your concerns but I'm lacking example code/documentation for it, maybe > > you can point me to an example on that and then I'll update my code accordingly. > > > > Have a look at Documentation/devicetree/bindings/gpio/gpio-fan.txt and > drivers/hwmon/gpio-fan.c.
Thanks a lot, this really helped me out. Updated patch is comming today including the bindings document Arnd Bergmann requested. I only need to rebase the sysfs patch on top of that changes.
Regards, Johannes
| |