lkml.org 
[lkml]   [2013]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] cpqarray: info leak in ida_locked_ioctl()
    The pciinfo struct has a two byte hole after ->dev_fn so stack
    information could be leaked to the user.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

    diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
    index 639d26b..2b94403 100644
    --- a/drivers/block/cpqarray.c
    +++ b/drivers/block/cpqarray.c
    @@ -1193,6 +1193,7 @@ out_passthru:
    ida_pci_info_struct pciinfo;

    if (!arg) return -EINVAL;
    + memset(&pciinfo, 0, sizeof(pciinfo));
    pciinfo.bus = host->pci_dev->bus->number;
    pciinfo.dev_fn = host->pci_dev->devfn;
    pciinfo.board_id = host->board_id;

    \
     
     \ /
      Last update: 2013-06-03 12:02    [W:0.022 / U:0.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site