[lkml]   [2013]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch] cciss: info leak in cciss_ioctl32_passthru()
    The arg64 struct has a hole after ->buf_size which isn't cleared.
    Or if any of the calls to copy_from_user() fail then that would
    cause an information leak as well.

    Signed-off-by: Dan Carpenter <>

    diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
    index 6374dc1..34971aa 100644
    --- a/drivers/block/cciss.c
    +++ b/drivers/block/cciss.c
    @@ -1201,6 +1201,7 @@ static int cciss_ioctl32_passthru(struct block_device *bdev, fmode_t mode,
    int err;
    u32 cp;

    + memset(&arg64, 0, sizeof(arg64));
    err = 0;
    err |=
    copy_from_user(&arg64.LUN_info, &arg32->LUN_info,

     \ /
      Last update: 2013-06-03 12:02    [W:0.020 / U:16.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site