lkml.org 
[lkml]   [2013]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Documentation: dt: bindings: TI WiLink modules
    From
    Date
    On Thu, 2013-06-27 at 08:23 -0500, Nishanth Menon wrote:
    > On 06/27/2013 08:19 AM, Luciano Coelho wrote:
    > > On Thu, 2013-06-27 at 08:15 -0500, Nishanth Menon wrote:
    > >> On Thu, Jun 27, 2013 at 7:58 AM, Luciano Coelho <coelho@ti.com> wrote:
    > >>> For the actual DTS files, I could add a wilink.dtsi with enumerations
    > >>> for these values so they could be used in the node definitions. But I'm
    > >>> not sure it's going to be that valuable in the end.
    > >> The way GPIO HIGH was defined might help to provide guidance I think :)
    > >
    > > Where? As far as I can see, the GPIO flags are defined in a bitmap.
    >
    > include/dt-bindings/gpio/gpio.h

    Thanks! I don't see these macros used anywhere, though.

    > And corresponding kernel header:
    > include/linux/of_gpio.h

    This seems to be a completely different thing. This is the header that
    contains the helper functions to get GPIO-related device tree nodes,
    isn't it?


    > just a hint. not saying frequencies were defined in header. for systems
    > that define frequencies - example cpufreq OPPs, clock node usage, we do
    > not use indexing to frequency, instead, that is the responsibility of
    > driver to convert frequency back to required index.
    > git grep frequency Documentation/devicetree/bindings gives you how the
    > precedence looks like.
    >
    > Personally, if given a choice, I'd go with actual frequencies rather
    > than indexes.

    If I do that, I need to add also a separate flag to define whether the
    XTAL clock is used or not. For instance, we have 26MHz and 26MHz
    crystal; and 38.4MHz and 38.4MHz crystal...

    --
    Luca.



    \
     
     \ /
      Last update: 2013-06-27 16:01    [W:4.997 / U:0.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site