lkml.org 
[lkml]   [2013]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 4/8] minnowboard: Add base platform driver for the MinnowBoard
    From
    On Wed, Jun 26, 2013 at 3:53 AM, Darren Hart <dvhart@linux.intel.com> wrote:

    > Provide a minimal public interface:
    > minnow_detect()
    > minnow_lvds_detect()
    > minnow_hwid()
    > minnow_phy_reset()

    So instead of these calling drivers issueing gpio_request() themselves
    to obtain a resource, they make a function call to this proxy that issue
    gpio_request() for them.

    This is generally not how we do things. A driver should request its
    GPIO just as it requests its regulator or clock or IRQ line or anything
    else. Centralizing resource handling is not a good idea IMO, it's better
    that each driver request it's GPIO pin(s) and do the stuff it needs
    with them.

    This of course creates the problem of associating the GPIOs to a
    driver and how it should look that up, which I guess ACPI can do,
    isn't that what acpi_find_gpio() is for?

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2013-06-27 12:01    [W:4.205 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site