Messages in this thread Patch in this message | | | Subject | [PATCH v4 2/5] rwsem: remove 'out' label in do_wake | From | Tim Chen <> | Date | Wed, 26 Jun 2013 15:27:57 -0700 |
| |
That make code simple and more readable.
Signed-off-by: Alex Shi <alex.shi@intel.com> --- lib/rwsem.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/rwsem.c b/lib/rwsem.c index 19c5fa9..42f1b1a 100644 --- a/lib/rwsem.c +++ b/lib/rwsem.c @@ -75,7 +75,7 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) * will block as they will notice the queued writer. */ wake_up_process(waiter->task); - goto out; + return sem; } /* Writers might steal the lock before we grant it to the next reader. @@ -91,7 +91,7 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) /* A writer stole the lock. Undo our reader grant. */ if (rwsem_atomic_update(-adjustment, sem) & RWSEM_ACTIVE_MASK) - goto out; + return sem; /* Last active locker left. Retry waking readers. */ goto try_reader_grant; } @@ -136,7 +136,6 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) sem->wait_list.next = next; next->prev = &sem->wait_list; - out: return sem; } -- 1.7.4.4
| |