Messages in this thread | | | Date | Wed, 26 Jun 2013 11:00:43 -0700 | From | Anton Vorontsov <> | Subject | Re: [PATCH] vmpressure: implement strict mode |
| |
On Wed, Jun 26, 2013 at 04:50:51PM +0900, Minchan Kim wrote: > On Tue, Jun 25, 2013 at 05:51:29PM -0400, Luiz Capitulino wrote: > > Currently, applications are notified for the level they registered for > > _plus_ higher levels. > > > > This is a problem if the application wants to implement different > > actions for different levels. For example, an application might want > > to release 10% of its cache on level low, 50% on medium and 100% on > > critical. To do this, the application has to register a different fd > > for each event. However, fd low is always going to be notified and > > and all fds are going to be notified on level critical. > > > > Strict mode solves this problem by strictly notifiying the event > > an fd has registered for. It's optional. By default we still notify > > on higher levels. > > > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> > Acked-by: Minchan Kim <minchan@kernel.org> > > Shouldn't we make this default? > What do you think about it?
Either way works and both modes have their use-cases (as I have described in my previous mail). Changing the default mode is just unneeded churn, IMO. As long as things are documented properly, we are good. :)
Thanks,
Anton
| |