Messages in this thread | | | Date | Wed, 26 Jun 2013 08:04:07 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges |
| |
On Wed, Jun 26, 2013 at 03:17:57PM +0300, Mika Westerberg wrote: > On Tue, Jun 25, 2013 at 02:15:56PM -0700, Jesse Barnes wrote: > > On Tue, 25 Jun 2013 19:22:10 +0300 > > Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > > > > > + if (!(pci_probe & PCI_NOASSIGN_ROMS)) { > > > + pr_info("Thunderbolt host router detected disabling ROMs\n"); > > > + pci_probe |= PCI_NOASSIGN_ROMS; > > > + } > > > > I wonder if this should just be the default on x86? Or do we allocate > > ROM space to address some other platform where we need it and the BIOS > > doesn't do it for the devices we care about? > > Good question. In our case it definitely helps to have pci=norom the > default. Can't tell if it might break something that depends on the current > behaviour. > > Bjorn, Greg, Rafael, > > What do you think?
I can't recall any specific reason to not do this, so no objection from me, but make it a nice and small patch that can easily be reverted if problems show up in the wild :)
thanks,
greg k-h
| |