Messages in this thread | | | Subject | Re: [PATCH v5 3/7] PCI: Use pci_walk_bus to detect unassigned resources | From | Benjamin Herrenschmidt <> | Date | Wed, 26 Jun 2013 07:38:15 +1000 |
| |
On Tue, 2013-06-25 at 15:15 -0600, Bjorn Helgaas wrote: > - for_each_pci_dev(dev) { > > - int i; > > + /* Not assigned, or rejected by kernel ? */ > > + if (r->flags && !r->start) { > > + (*unassigned)++; > > + return 1; /* return early from pci_walk_bus */ > > + } > > + }
BTW. I'm aware you didn't change that logic but ... it's somewhat broken in the case where the aperture has an offset. You should compare r->start with the offset, not with 0.
Cheers, Ben.
| |