lkml.org 
[lkml]   [2013]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] tracing/kprobes: move free_trace_probe into unregister_trace_probe
    From
    Date
    On Tue, 2013-06-25 at 19:10 +0900, Masami Hiramatsu wrote:
    > (2013/06/25 17:15), zhangwei(Jovi) wrote:
    > > There have no good reason to call free_trace_probe
    > > every time when unregister_trace_probe return 0.
    > >
    > > Move free_trace_probe into unregister_trace_probe,
    > > make code simpler.
    >
    > Sorry, nack. For the symmetrical coding reason, I don't like
    > involving "free" and "alloc" into "unregister"/"register"
    > functions. I think those should be just another actions.

    I totally agree with Masami here. Please do not add "side effects" to
    the unregister function.

    Thanks,

    -- Steve



    \
     
     \ /
      Last update: 2013-06-25 16:21    [W:3.036 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site