Messages in this thread | | | Date | Sat, 22 Jun 2013 14:02:05 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver |
| |
On 06/22/2013 01:55 PM, Jonathan Cameron wrote: > On 06/20/2013 07:57 PM, Alexandre Belloni wrote: >> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable >> gain and sampling rates. >> > Sorry, somewhat low on time today so only a quick review. > > 1) Missing userspace ABI documentation. Also, perhaps min_conversions is > a little vague? Not that I have a better idea!
I really don't like the name min_conversions either. Isn't this effectively a decimation filter?
- Lars
| |