lkml.org 
[lkml]   [2013]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller
    On Thu, 20 Jun 2013, Felipe Balbi wrote:

    > > In fact, the PHY setting and handling is related to platform or SOC,
    > > and for different SOC they can
    > > have same EHCI HCD but they PHY handling can be different.
    > > Omap'a case is the example, and i think some other vendors may have
    > > silimar cases.
    > > From above point, It is better to leave the PHY initialization and
    > > shutdown to be done by each echi-xxx driver.
    > >
    > > So Alan and Felipe
    > > What are your ideas about it?
    >
    > If we have so many exceptions, then sure. But eventually, the common
    > case should be added generically with a flag so that non-generic cases
    > (like OMAP) can request to handle the PHY by themselves.
    >
    > Alan ?

    I don't have very strong feelings about this; Felipe has much more
    experience with these things.

    However, when the common case is added into the core, the simplest way
    to indicate that the HCD wants to handle the PHY(s) by itself will be
    to leave hcd->phy set to NULL or an ERR_PTR value.

    One important thing that hasn't been pointed out yet: When we move
    these calls into the core, the same patch must also remove those calls
    from the glue drivers that currently do set hcd->phy. And it must make
    sure that the glue drivers which handle the PHY by themselves do not
    set hcd->phy.

    Alan Stern



    \
     
     \ /
      Last update: 2013-06-20 19:41    [W:4.176 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site