Messages in this thread | | | Date | Thu, 20 Jun 2013 11:38:25 +0100 | From | "Jan Beulich" <> | Subject | Re: [Xen-devel] [PATCH 1/4] xen: disable non-boot VCPUs during suspend |
| |
>>> On 19.06.13 at 17:25, David Vrabel <david.vrabel@citrix.com> wrote: > syscore_suspend() and syscore_resume() expect there to be only one > online CPU. e.g., hrtimers_resume() only triggers events for the > current CPU. Xen's suspend path was leaving all VCPUs online and then > attempting to fixup problems afterwards (e.g., with an explicit call > to clock_was_set() to trigger pending high resolution timers). > > Instead, disable non-boot CPUs before calling stop_machine() and > reenable them afterwards.
In XenoLinux the so called "fast suspend" mode was specifically added for performance reasons, and it looks like to date pv-ops only ever supported that mode. So one question is whether there's going to be any bad performance effect from this.
The other question is that about retaining the use of stop_machine() then - it seems pretty pointless if you already bring down all other CPUs.
Jan
| |