lkml.org 
[lkml]   [2013]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] page_isolation: Fix a comment typo in test_pages_isolated()
On 06/20/2013 06:10 PM, Tang Chen wrote:
> pageblock_nr_page should be pageblock_nr_pages, and fist is
> a typo of first.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> ---
> mm/page_isolation.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> index 383bdbb..0cee10f 100644
> --- a/mm/page_isolation.c
> +++ b/mm/page_isolation.c
> @@ -226,9 +226,9 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
> int ret;
>
> /*
> - * Note: pageblock_nr_page != MAX_ORDER. Then, chunks of free page
> - * is not aligned to pageblock_nr_pages.
> - * Then we just check pagetype fist.
> + * Note: pageblock_nr_pages != MAX_ORDER. Then, chunks of free pages

pageblock_nr_pages is the count of pages while MAX_ORDER is a order. Here
may be pageblock_order != MAX_ORDER.

> + * are not aligned to pageblock_nr_pages.
> + * Then we just check migratetype first.
> */
> for (pfn = start_pfn; pfn < end_pfn; pfn += pageblock_nr_pages) {
> page = __first_valid_page(pfn, pageblock_nr_pages);
> @@ -238,7 +238,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
> page = __first_valid_page(start_pfn, end_pfn - start_pfn);
> if ((pfn < end_pfn) || !page)
> return -EBUSY;
> - /* Check all pages are free or Marked as ISOLATED */
> + /* Check all pages are free or marked as ISOLATED */
> zone = page_zone(page);
> spin_lock_irqsave(&zone->lock, flags);
> ret = __test_page_isolated_in_pageblock(start_pfn, end_pfn,


--
Thanks.
Zhang Yanfei


\
 
 \ /
  Last update: 2013-06-20 15:41    [W:0.292 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site