lkml.org 
[lkml]   [2013]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] USB: serial: ti_usb_3410_5052: Be explicit about the Abbott product ids being product ids.
On Wed, Jun 19, 2013 at 01:58:49AM +0200, Anders Hammarquist wrote:
> Be explicit about the Abbott product ids being product ids.
>
> Signed-off-by: Anders Hammarquist <iko@iko.pp.se>
> ---
> drivers/usb/serial/ti_usb_3410_5052.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/ti_usb_3410_5052.h b/drivers/usb/serial/ti_usb_3410_5052.h
> index 4a2423e..ea8b273 100644
> --- a/drivers/usb/serial/ti_usb_3410_5052.h
> +++ b/drivers/usb/serial/ti_usb_3410_5052.h
> @@ -52,9 +52,9 @@
>
> /* Abbott Diabetics vendor and product ids */
> #define ABBOTT_VENDOR_ID 0x1a61
> -#define ABBOTT_STEREO_PLUG_ID 0x3410
> +#define ABBOTT_STEREO_PLUG_PRODUCT_ID 0x3410
> #define ABBOTT_PRODUCT_ID ABBOTT_STEREO_PLUG_ID

Can you just delete ABBOTT_PRODUCT_ID here, because if you ever use it,
you will get a build error, right?

I'll just take the first patch for now, please resend this one.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-06-20 01:21    [W:0.112 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site