Messages in this thread | | | Date | Wed, 19 Jun 2013 16:37:17 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 3/4] GPIO: Add TB10x GPIO driver |
| |
On 06/18/2013 03:29 AM, Christian Ruppert wrote: > The GPIO driver for the Abilis Systems TB10x series of SOCs based on ARC700 > CPUs. It supports GPIO control and GPIO interrupt generation. This driver > works in conjunction with the TB10x pinctrl driver.
Just one comment on the binding (I didn't read the code):
> diff --git a/Documentation/devicetree/bindings/gpio/abilis,tb10x-gpio.txt b/Documentation/devicetree/bindings/gpio/abilis,tb10x-gpio.txt
> +Required Properties:
> +- ngpio: the number of GPIO pins this driver controls.
That's a custom property, so should include a vendor prefix: abilis,ngpios.
| |