Messages in this thread Patch in this message | | | Date | Wed, 19 Jun 2013 18:40:47 +0100 | From | Mark Brown <> | Subject | Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA |
| |
On Sun, Jun 16, 2013 at 10:54:07PM +0200, Tomasz Figa wrote: > One of the biggest roadblocks on the way of S3C64xx to DeviceTree support > is its DMA driver, which is completely platform-specific and provides > private API (s3c-dma), not even saying that its design is completely > against multiplatform-awareness.
I tried to test this on my s3c64xx based system but it gave me a kernel that didn't boot far enough to give console output (there's some early init stuff that uses SPI...). That said, I needed:
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 210a893..0f49707 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -313,7 +313,7 @@ static int pl08x_request_mux(struct pl08x_dma_chan *plchan) int ret; if (plchan->mux_use++ == 0 && pd->get_signal) { - ret = pd->get_signal(plchan->cd); + ret = (pd->get_signal)(plchan->cd); if (ret < 0) { plchan->mux_use = 0; return ret; to get it to build which makes me suspect the compiler a bit as well... the system has audio, SPI and MMC enabled.
I was applying this to -next, are there any other dependencies I need or anything? [unhandled content-type:application/pgp-signature] | |