Messages in this thread | | | Date | Tue, 18 Jun 2013 09:32:32 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2] net: fec: Fix build for MCF5272 |
| |
On Tue, Jun 18, 2013 at 01:23:13PM -0300, Fabio Estevam wrote: > On Tue, Jun 18, 2013 at 12:38 PM, Guenter Roeck <linux@roeck-us.net> wrote: > > Commits 4c09eed9 (net: fec: Enable imx6 enet checksum acceleration) and > > baa70a5c (net: fec: enable pause frame to improve rx prefomance for 1G > > network) introduced functionality into the FEC driver which is not > > supported on MCF5272. The registers used to implement this functionality > > do not exist on MCF5272. Since register defines for MCF5272 are separate > > from register defines for other chips, building images for MCF5272 fails, > > complaining about several undefined symbols. > > > > Adding the missing register defines is not an option, since the registers > > do not exist on MCF5272. Disable the added functionality for MCF5272 builds. > > Can you please show the build error message you got? > > Also, it would be nice if FEC could be enabled by default on some m68k > defconfig, so that we could spot issues like this earlier. > Try building m5272c3_defconfig; this is actually how I found the problem when test-building v3.9.6-rc1.
make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- mrproper make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- m5272c3_defconfig make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu-
results in:
drivers/net/ethernet/freescale/fec_main.c: In function ‘fec_restart’: drivers/net/ethernet/freescale/fec_main.c:520:8: error: ‘FEC_RACC’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec_main.c:520:8: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/freescale/fec_main.c:585:3: error: ‘FEC_R_FIFO_RSEM’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec_main.c:586:3: error: ‘FEC_R_FIFO_RSFL’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec_main.c:587:3: error: ‘FEC_R_FIFO_RAEM’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec_main.c:588:3: error: ‘FEC_R_FIFO_RAFL’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec_main.c:591:3: error: ‘FEC_OPD’ undeclared (first use in this function)
with v3.10-rc6,
and
drivers/net/ethernet/freescale/fec.c: In function ‘fec_restart’: drivers/net/ethernet/freescale/fec.c:530:3: error: ‘FEC_R_FIFO_RSEM’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec.c:530:3: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/freescale/fec.c:531:3: error: ‘FEC_R_FIFO_RSFL’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec.c:532:3: error: ‘FEC_R_FIFO_RAEM’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec.c:533:3: error: ‘FEC_R_FIFO_RAFL’ undeclared (first use in this function) drivers/net/ethernet/freescale/fec.c:536:3: error: ‘FEC_OPD’ undeclared (first use in this function)
with 3.9.6.
Want me to add it to the commit log ?
Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |