Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] ACPI / dock: Take ACPI scan lock in write_undock() | Date | Tue, 18 Jun 2013 23:43:27 +0200 |
| |
On Tuesday, June 18, 2013 03:28:37 PM Toshi Kani wrote: > On Sun, 2013-06-16 at 00:16 +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > Since commit 3757b94 (ACPI / hotplug: Fix concurrency issues and > > memory leaks) acpi_bus_scan() and acpi_bus_trim() must always be > > called under acpi_scan_lock, but currently the following scenario > > violating that requirement is possible: > > > > write_undock() > > handle_eject_request() > > hotplug_dock_devices() > > dock_remove_acpi_device() > > acpi_bus_trim() > > > > Fix that by making write_undock() acquire acpi_scan_lock before > > calling handle_eject_request() as appropriate (begin_undock() is > > under the lock too in analogy with acpi_dock_deferred_cb()). > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Looks good. > > Acked-by: Toshi Kani <toshi.kani@hp.com>
Thanks!
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |