lkml.org 
[lkml]   [2013]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 43/93] drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC.
    Date
    3.5.7.15 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Egbert Eich <eich@suse.de>

    commit 53d3b4d7778daf15900867336c85d3f8dd70600c upstream.

    In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used
    for DDC. Thus the code will always have to rely on a LVDS panel
    mode supplied by VBT.
    In most cases this succeeds, so this didn't get detected for quite
    a while.

    This regression seems to have been introduced in

    commit f899fc64cda8569d0529452aafc0da31c042df2e
    Author: Chris Wilson <chris@chris-wilson.co.uk>
    Date: Tue Jul 20 15:44:45 2010 -0700

    drm/i915: use GMBUS to manage i2c links

    Signed-off-by: Egbert Eich <eich@suse.de>
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    [danvet: Add note about which commit likely introduced this issue.]
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/gpu/drm/i915/intel_sdvo.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
    index 1af5db5..63b53d2 100644
    --- a/drivers/gpu/drm/i915/intel_sdvo.c
    +++ b/drivers/gpu/drm/i915/intel_sdvo.c
    @@ -1595,7 +1595,7 @@ static void intel_sdvo_get_lvds_modes(struct drm_connector *connector)
    * Assume that the preferred modes are
    * arranged in priority order.
    */
    - intel_ddc_get_modes(connector, intel_sdvo->i2c);
    + intel_ddc_get_modes(connector, &intel_sdvo->ddc);
    if (list_empty(&connector->probed_modes) == false)
    goto end;

    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-06-19 01:01    [W:4.085 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site