Messages in this thread Patch in this message | | | From | Joe Perches <> | Subject | [PATCH] checkpatch: Ignore SI unit CamelCase variants like "_uV" | Date | Tue, 18 Jun 2013 14:49:00 -0700 |
| |
Many existing variable names use SI like variants that should be otherwise obvious and acceptable.
Whitelist them from the CamelCase message.
Suggested-by: Phil Carmody <phil.carmody@partner.samsung.com> Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 5989415..7e8aa1b 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3195,7 +3195,10 @@ sub process { #CamelCase if ($var !~ /^$Constant$/ && $var =~ /[A-Z][a-z]|[a-z][A-Z]/ && +#Ignore Page<foo> variants $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && +#Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show) + $var !~ /^(?:[a-z_]*?)_?[a-z][A-Z](?:_[a-z_]+)?$/ && !defined $camelcase{$var}) { $camelcase{$var} = 1; CHK("CAMELCASE", -- 1.8.1.2.459.gbcd45b4.dirty
| |